Setup GitHub Actions build and unit test CI jobs#418
Merged
derrickstolee merged 1 commit intomicrosoft:mainfrom Aug 18, 2020
Merged
Setup GitHub Actions build and unit test CI jobs#418derrickstolee merged 1 commit intomicrosoft:mainfrom
derrickstolee merged 1 commit intomicrosoft:mainfrom
Conversation
We define GitHub Actions YAML which runs a simplified version of
the BuildScalarFor*.{bat,sh} and RunUnitTests.{bat,sh} scripts
under Scripts/.
One difference is that we use a Release build configuration
instead of using a Build configuration as our default.
We also do not define the ScalarVersion MSBuild property and
instead rely on what is set in Directory.Build.props.
h/t kyle-rader
derrickstolee
approved these changes
Aug 17, 2020
Contributor
derrickstolee
left a comment
There was a problem hiding this comment.
LGTM. An excellent milestone!
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We define GitHub Actions YAML which runs a simplified version of the
BuildScalarFor*.{bat,sh}andRunUnitTests.{bat,sh}scripts underScripts/. We run these jobs on all PRs to themainbranch.One difference is that we use a
Releasebuild configuration instead of using aBuildconfiguration as our default.We also do not define the
ScalarVersionMSBuild property and instead rely on what is set inDirectory.Build.props.We include builds on three Ubuntu versions to align with what runs for GCM Core, and to support Linux functional test runs in the future. These jobs should succeed as-is even without Linux-specific platform code; see https://github.com/chrisd8088/scalar/actions/runs/211493921 for an example run.
/cc @kyle-rader
/cc git-ecosystem/git-credential-manager#157 from which this was derived