ScalarCloneFromGitHub: drop SSH string#417
Merged
derrickstolee merged 1 commit intomicrosoft:mainfrom Aug 14, 2020
Merged
Conversation
This string was added when toying with testing SSH URLs in the functional tests. However, there was an issue with using SSH inside the build machines, so it was never used. It's now creating pain for the GitHub Actions workflows that will build Scalar. Drop it. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This string was added when toying with testing SSH URLs in the
functional tests. However, there was an issue with using SSH inside the
build machines, so it was never used. It's now creating pain for the
GitHub Actions workflows that will build Scalar. Drop it.
(This was noticed by the warnings in #413.)