Delete several unused methods and types#405
Merged
mjcheetham merged 6 commits intomicrosoft:mainfrom Jul 15, 2020
Merged
Conversation
Remove unused Scalar and Git version properties from the ScalarEnlistment type.
Remove various file system and path manipulation code that was no longer used anywhere. Much was cruft carried over from VFS for Git.
Remove unsued enlistment ID methods and tests.
Delete several unused types (and their tests). Many of these types were only referenced by themselves, or their own unit tests! These are a hold-over from the forking from VFS for Git.
derrickstolee
approved these changes
Jul 15, 2020
Contributor
derrickstolee
left a comment
There was a problem hiding this comment.
Thanks for the thorough investigation!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we forked the code from VFS for Git we brought over a lot of things that are not required. We're still carrying them around and they should be removed - we have no use for them and will not need them.
In many cases the only 'references' to these types were either themselves, or their own unit tests.