git-hooks: resolve git symlink on Mac to find hooks#402
Merged
mjcheetham merged 1 commit intomicrosoft:mainfrom Jul 15, 2020
Merged
git-hooks: resolve git symlink on Mac to find hooks#402mjcheetham merged 1 commit intomicrosoft:mainfrom
mjcheetham merged 1 commit intomicrosoft:mainfrom
Conversation
dscho
reviewed
Jul 13, 2020
Member
dscho
left a comment
There was a problem hiding this comment.
It is too bad that there is no way to ask Git "where are your templates, friend?"
a3d7fa6 to
4332081
Compare
jeffhostetler
approved these changes
Jul 14, 2020
dscho
approved these changes
Jul 14, 2020
Member
dscho
left a comment
There was a problem hiding this comment.
I have no further suggestions in addition to the ones already provided by @derrickstolee and @jeffhostetler.
Replace the hardcoded /usr/local/git/ base installation path on macOS with a `which git` and symlink resolution, to ensure we always find the correct hooks template directory. This works for the Homebrew installed Git, or the .pkg installed Git. Apple-Git would work, but it does not ship with any hook templates anyway!
4332081 to
ad3c8d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the hardcoded /usr/local/git/ base installation path on macOS
with a
which gitand symlink resolution, to ensure we always find thecorrect hooks template directory.
This works for the Homebrew installed Git, or the .pkg installed Git.
Apple-Git would work, but it does not ship with any hook templates
anyway!
Fixes #401