Rename cleanup: Old "VFS4G" now "Scalar"#40
Merged
derrickstolee merged 1 commit intomicrosoft:masterfrom Aug 12, 2019
derrickstolee:vfs4g-replace
Merged
Rename cleanup: Old "VFS4G" now "Scalar"#40derrickstolee merged 1 commit intomicrosoft:masterfrom derrickstolee:vfs4g-replace
derrickstolee merged 1 commit intomicrosoft:masterfrom
derrickstolee:vfs4g-replace
Conversation
When doing the rename, I converted all instances of "VFS" to "Scalar" without first replacing the string "VFS4G". This left a bunch of "Scalar4G" instances around the codebase. Fix that using the same replace logic as before. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
jrbriggs
approved these changes
Aug 12, 2019
Member
jrbriggs
left a comment
There was a problem hiding this comment.
Thanks for following up on this!
Contributor
Author
|
/azp run microsoft.scalar |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When doing the rename, I converted all instances of "VFS" to "Scalar"
without first replacing the string "VFS4G". This left a bunch of
"Scalar4G" instances around the codebase. Fix that using the same
replace logic as before.
Fixes a comment from #38.