Fix commit-graph expiration#362
Merged
derrickstolee merged 2 commits intomicrosoft:masterfrom Apr 2, 2020
Merged
Conversation
See microsoft/git#255. For some reason I got myself confused as to what --expire-time was for. The command-line interface says one thing while the internal implementation does something different. Scalar and VFS for Git were doing what the internal implementation was expecting, but the option parsing was not properly reflecting the data correctly. This means that a lot of users have an excess of commit-graph files in their object directories. This will quickly clean them all up. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
1d29346 to
d72985f
Compare
kewillford
approved these changes
Apr 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wow, this was really not working as expected.
See microsoft/git#255 for how broken the
--expire-timeargument was.Fix this by using the fixed argument and passing a datetime instead of an offset by seconds. This will provide a longer window for old commit-graph files, but apparently we've been leaving turd files around for a long time without anyone noticing.