Skip to content

Cleanups following gvfs-helper#150

Merged
derrickstolee merged 3 commits intomicrosoft:masterfrom
derrickstolee:gvfs-helper-cleanups
Oct 4, 2019
Merged

Cleanups following gvfs-helper#150
derrickstolee merged 3 commits intomicrosoft:masterfrom
derrickstolee:gvfs-helper-cleanups

Conversation

@derrickstolee
Copy link
Contributor

@derrickstolee derrickstolee commented Oct 4, 2019

Here are a few leftovers from #71

  • There were a few more "readobject" strings in the codebase.

  • The PackfileMaintenanceStepTests were disabled, but now they are re-enabled and adjusted to the new gvfs-helper environment.

  • The PrefetchVerb no longer does anything but the commits and trees prefetch, so drop the --commits option.

@derrickstolee
Remove all references to the read-object hook
81e831d 
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
@derrickstolee
PackfileMaintenanceStepTests: update tests for new initial pack layout
f5d0d5a 
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
@derrickstolee
PrefetchVerb: drop --commits option
bdab865 
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
@derrickstolee derrickstolee added this to the MVP milestone Oct 4, 2019
@wilbaker
Copy link
Member

wilbaker commented Oct 4, 2019

@derrickstolee unrelated to these specific changes, I saw that this change:

It's not! I thought it would speed up the test, but in fact it makes the test do nothing of value. I'll remove this and try the speed-up later (while also making these enlistments sparse).

I'll drop it from this PR.

Did end up getting merged in as part of #122, was that intentional? If not, should it get backed out in this PR?

@derrickstolee
Copy link
Contributor Author

derrickstolee commented Oct 4, 2019 •
edited
Loading

It's not! I thought it would speed up the test, but in fact it makes the test do nothing of value. I'll remove this and try the speed-up later (while also making these enlistments sparse).

I'll drop it from this PR.

Did end up getting merged in as part of #122, was that intentional? If not, should it get backed out in this PR?

Thanks for catching that, @wilbaker! I definitely thought I had changed that, but must have forgotten. I'll get it in this one.

@derrickstolee derrickstolee mentioned this pull request Oct 4, 2019
Closed
@derrickstolee
Copy link
Contributor Author

derrickstolee commented Oct 4, 2019

I removed the test change as it broke the build. I filed #156 to track fixing that test.

@derrickstolee derrickstolee merged commit a3613f8 into microsoft:master Oct 4, 2019
@derrickstolee derrickstolee deleted the gvfs-helper-cleanups branch November 18, 2019 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@wilbaker wilbaker wilbaker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cleanup

Projects

None yet

Milestone

MVP

Development

Successfully merging this pull request may close these issues.

2 participants

@derrickstolee @wilbaker