Adding telegram bot token validator#587
Merged
Merged
Conversation
| "MessageArguments": { "secretKind": "Crates API key" } | ||
| }, | ||
| { | ||
| "Id": "SEC101/049", |
Member
Collaborator
Author
There was a problem hiding this comment.
it is the other open pr
| case HttpStatusCode.Forbidden: | ||
| case HttpStatusCode.Unauthorized: | ||
| { | ||
| return ValidationState.Unauthorized; |
Member
Collaborator
Author
There was a problem hiding this comment.
we have, but we require an id, for example. in this case, this does not apply.
| string content = response.Content.ReadAsStringAsync().GetAwaiter().GetResult(); | ||
| ResultRoot resultRoot = JsonConvert.DeserializeObject<ResultRoot>(content); | ||
|
|
||
| fingerprint.Id = resultRoot?.Result?.Username; |
Member
Collaborator
Author
There was a problem hiding this comment.
in the cosmos analysis, it would change only the asset fingerprint.
in the client analysis, yes, it would change both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This is a new rule which will look for telegram bot tokens. If any match is found, the dynamic validation will be able to check if this is still live or not, updating the
finngerprint.idwith the username of the bot if available.For significant contributions please make sure you have completed the following items:
ReleaseHistory.mdupdated for non-trivial changes