Skip to content

Exposing automationId, automationGuid, and postUri in the analyze command.#586

Merged
eddynaka merged 2 commits into
mainfrom
users/ednakamu/updating-submodules
Dec 1, 2021
Merged

Exposing automationId, automationGuid, and postUri in the analyze command.#586
eddynaka merged 2 commits into
mainfrom
users/ednakamu/updating-submodules

Conversation

@eddynaka

@eddynaka eddynaka commented Nov 30, 2021

Copy link
Copy Markdown
Collaborator

Changes

Updating the sarif-sdk submodule will enable us to expose three new parameters for the analyze command: postUri, automationId, and automationGuid.

Below is one example of the new command-line arguments:

❯ .\spam.exe analyze c:\temp\ -o c:\test.sarif --force -d C:\Rules.json --automationId "Test" --automationGuid BC6CCB9F-16C8-4656-A227-C7B5F34864FA --postUri http://localhost:7072/api/upload-content

For significant contributions please make sure you have completed the following items:

  • ReleaseHistory.md updated for non-trivial changes
  • Added unit tests

@eddynaka eddynaka changed the title Updating submodules Exposing automationId, automationGuid, and postUri in the analyze command. Nov 30, 2021
@eddynaka eddynaka marked this pull request as ready for review November 30, 2021 19:42
var keyValuePairs = new Dictionary<string, string>();

using var httpClient = new HttpClient(HttpMockHelper.Mock(testCase.HttpStatusCode, testCase.HttpContent));
using var httpClient = new HttpClient(Helpers.HttpMockHelper.Mock(testCase.HttpStatusCode, testCase.HttpContent));

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helpers.

the sarif code now contains the same httpmock infrastructure.

will have to check if we should drop from this or something else.

@eddynaka eddynaka merged commit fa9f65b into main Dec 1, 2021
@eddynaka eddynaka deleted the users/ednakamu/updating-submodules branch December 1, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants