Skip to content

Improving SendGridApiKeyValidator#562

Merged
eddynaka merged 2 commits into
mainfrom
users/ednakamu/improving-sendgrid-validator
Sep 28, 2021
Merged

Improving SendGridApiKeyValidator#562
eddynaka merged 2 commits into
mainfrom
users/ednakamu/improving-sendgrid-validator

Conversation

@eddynaka

@eddynaka eddynaka commented Sep 28, 2021

Copy link
Copy Markdown
Collaborator

Changes

  • Refactoring validator using scopes API to retrieve the permissions
  • Adding tests to increase code coverage

image

For significant contributions please make sure you have completed the following items:

  • ReleaseHistory.md updated for non-trivial changes
  • Added unit tests

@eddynaka eddynaka marked this pull request as ready for review September 28, 2021 20:20
@eddynaka eddynaka merged commit 0bec935 into main Sep 28, 2021
@eddynaka eddynaka deleted the users/ednakamu/improving-sendgrid-validator branch September 28, 2021 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants