Removing redundant TryGetNonEmptyValue when key is required#539
Merged
Conversation
Member
|
Eddy, where is the release note describing this change? No more changes of this kind without documenting them in the release notes, please. :) Note that this change is actually key to document as we will now aggressively raise exceptions in cases where we previously did not! In reply to: 899106233 |
Member
this shouldn't work! this is a very old fingerprint. does this test need updating? In reply to: 899106459 Refers to: Src/Plugins/Tests.Security/Validators/SEC101_102.AdoPatValidatorTests.cs:76 in c0b866e. [](commit_id = c0b866e, deletion_comment = False) |
| string failureLevel = testCase.FailureLevel; | ||
| string fingerprintText = null; | ||
| var groups = new Dictionary<string, FlexMatch>(); | ||
| var groups = new Dictionary<string, FlexMatch> |
Member
Collaborator
Author
There was a problem hiding this comment.
This was a strange test.
I removed a few things and started validating the expected count and state.
Collaborator
Author
Collaborator
Author
|
Added a new entry In reply to: 899106233 |
|
|
||
| ## Unreleased | ||
|
|
||
| - Plugin Improvement: Required properties will throw exception if it does not exist. [#539](https://github.com/microsoft/sarif-pattern-matcher/pull/539) |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
ReleaseHistory.mdupdated for non-trivial changes