Skip to content

Improving regex patterns#533

Merged
eddynaka merged 3 commits into
mainfrom
users/ednakamu/improving-regex
Aug 11, 2021
Merged

Improving regex patterns#533
eddynaka merged 3 commits into
mainfrom
users/ednakamu/improving-regex

Conversation

@eddynaka

@eddynaka eddynaka commented Aug 11, 2021

Copy link
Copy Markdown
Collaborator

This change is replacing \b for the following patterns:

(?:[^some_pattern]|^)
(?:[^some_pattern]|$)

Iv1.01234567testtest
</GitHubId>

********************************************************************************

@eddynaka eddynaka Aug 11, 2021

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleaning up duplicated tests since we have intrafile search for this rule #ByDesign

Comment thread Src/Changelog.md Outdated
@@ -0,0 +1,664 @@
# Changelog

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog

creating a changelog.md and will update in a follow-up pr the releasehistory.md with relevant changes.

@michaelcfanning michaelcfanning Aug 11, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have two files? Are we really going to maintain change log in this way, manually? i.e., describe the developer maintenance process to me.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changelog is something auto-generated
the releasehistory is basically the relevant changes.

@michaelcfanning michaelcfanning left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@eddynaka eddynaka merged commit 336afda into main Aug 11, 2021
@eddynaka eddynaka deleted the users/ednakamu/improving-regex branch August 11, 2021 17:51
@michaelcfanning michaelcfanning mentioned this pull request Aug 25, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants