fix(metro-service): cli-plugin-metro has been deprecated#2589
Merged
Conversation
acoates-ms
approved these changes
Aug 7, 2023
Sync to the latest changes and don't depend on it for bundling. `@react-native-community/cli-plugin-metro` is being moved into the `react-native` repository. In the process, it was renamed and its API surface has been reduced to the bare minimum. `buildBundleWithConfig`, which we need to pass our custom config to the bundler, has also been axed. For more details, see facebook/react-native#38795.
dbe12e7 to
32f73c5
Compare
|
Huge thanks for moving fast with this! Endorsed ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sync to the latest changes and don't depend on it for bundling.
@react-native-community/cli-plugin-metrois being moved into thereact-nativerepository. In the process, it was renamed and its API surface has been reduced to the bare minimum.buildBundleWithConfig, which we need to pass our custom config to the bundler, has also been axed.Resolves #328.
Test plan