Conversation
rzhao271
previously requested changes
Sep 8, 2025
Contributor
rzhao271
left a comment
There was a problem hiding this comment.
The patches also have to be updated.
Contributor
|
Fixes #38 |
rzhao271
reviewed
Sep 11, 2025
| parameters: | ||
| target: '' | ||
| rust_version: 'ms-stable' | ||
| rust_version: 'ms-1.85' |
Contributor
There was a problem hiding this comment.
I changed to a newer feed. ms-stable used to mean ms-1.85, so I'm keeping the version at ms-1.85 for now.
| + | ||
| +# -Clink-args=/DYNAMICBASE /CETCOMPAT: Enable "shadow stack" (https://learn.microsoft.com/en-us/cpp/build/reference/cetcompat) | ||
| +[target.'cfg(all(target_os = "windows", any(target_arch = "i686", target_arch = "x86_64", target_arch = "x86")))'] | ||
| +rustflags = ["-Clink-args=/DYNAMICBASE /CETCOMPAT /sdl"] |
Contributor
There was a problem hiding this comment.
This PR removes -Cehcont_guard and /sdl in order to keep the build green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.