Skip to content

chore: remove APIScan#46

Merged
rzhao271 merged 1 commit intomainfrom
rzhao271/inquisitive-sloth
Nov 7, 2024
Merged

chore: remove APIScan#46
rzhao271 merged 1 commit intomainfrom
rzhao271/inquisitive-sloth

Conversation

@rzhao271
Copy link
Contributor

@rzhao271 rzhao271 commented Nov 7, 2024

This PR removes APIScan for the ripgrep-prebuilt pipeline considering that:

  1. We have already handled APIScan results for ripgrep-prebuilt.
  2. The ADO organization in which the pipeline runs does not support a WIF Service Connection to APIScan.
  3. The only file to scan is rg.exe, which is a Rust binary. APIScan currently does not support Rust binaries, anyway, meaning it would be more appropriate for us to periodically manually review the upstream project and its HVP calls.

@rzhao271 rzhao271 self-assigned this Nov 7, 2024
@rzhao271 rzhao271 added this to the November 2024 milestone Nov 7, 2024
@rzhao271 rzhao271 marked this pull request as ready for review November 7, 2024 21:24
@rzhao271 rzhao271 enabled auto-merge (squash) November 7, 2024 21:24
@rzhao271 rzhao271 merged commit 05625d7 into main Nov 7, 2024
@rzhao271 rzhao271 deleted the rzhao271/inquisitive-sloth branch November 7, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants