Skip to content

ARM64 support for Universal#3909

Merged
13 commits merged into
microsoft:masterfrom
jurocha-ms:arm64-uwp
Jan 22, 2020
Merged

ARM64 support for Universal#3909
13 commits merged into
microsoft:masterfrom
jurocha-ms:arm64-uwp

Conversation

@JunielKatarn

@JunielKatarn JunielKatarn commented Jan 18, 2020 •
edited by ghost
Loading

Copy link
Copy Markdown
Contributor

Enable building for the ARM64 platform (Universal projects only).

Microsoft Reviewers: Open in CodeFlow

@JunielKatarn JunielKatarn requested a review from a team as a code owner January 18, 2020 02:05
@JunielKatarn JunielKatarn mentioned this pull request Jan 18, 2020
Closed
kmelmon
kmelmon reviewed Jan 18, 2020
View reviewed changes
Comment thread .ado/windows-vs-pr.yml
@kmelmon

kmelmon commented Jan 18, 2020

Copy link
Copy Markdown
Contributor

Can you also add ARM64 support to the CLI template project (for apps generated by react-native windows)? See:
vnext\local-cli\generator-windows\templates\cs\proj
and
vnext\local-cli\generator-windows\templates\cpp\proj

To test see: https://github.com/microsoft/react-native-windows/wiki/Contributing-to-the-CLI

@JunielKatarn

JunielKatarn commented Jan 21, 2020

Copy link
Copy Markdown
Contributor Author

Can you also add ARM64 support to the CLI template project (for apps generated by react-native windows)? See:
vnext\local-cli\generator-windows\templates\cs\proj
and
vnext\local-cli\generator-windows\templates\cpp\proj

To test see: https://github.com/microsoft/react-native-windows/wiki/Contributing-to-the-CLI

Done.

@JunielKatarn JunielKatarn added the AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) label Jan 21, 2020
@ghost

ghost commented Jan 21, 2020

Copy link
Copy Markdown

Hello @JunielKatarn!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@JunielKatarn JunielKatarn requested a review from kmelmon January 21, 2020 20:32
@kmelmon

kmelmon commented Jan 21, 2020

Copy link
Copy Markdown
Contributor

Thanks!

In reply to: 576866631 [](ancestors = 576866631)

kmelmon
kmelmon approved these changes Jan 21, 2020
View reviewed changes

@kmelmon kmelmon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JunielKatarn

JunielKatarn commented Jan 21, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Blocked by ReactWindows/yoga#2

This was referenced Jan 21, 2020
Closed
Closed
NickGerleman
NickGerleman reviewed Jan 22, 2020
View reviewed changes
Comment thread vnext/Common/Common.vcxproj
@ghost ghost merged commit cd60ff5 into microsoft:master Jan 22, 2020
@JunielKatarn JunielKatarn deleted the arm64-uwp branch January 22, 2020 01:34
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acoates-ms acoates-ms Awaiting requested review from acoates-ms

2 more reviewers

@NickGerleman NickGerleman NickGerleman left review comments

@kmelmon kmelmon kmelmon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JunielKatarn @kmelmon @NickGerleman