Skip to content

[0.76] [Telemetry] Address package name limitations - Take 2#14262

Merged
danielayala94 merged 2 commits intomicrosoft:0.76-stablefrom
danielayala94:backportTelemetryPackageNames076
Jan 10, 2025
Merged

[0.76] [Telemetry] Address package name limitations - Take 2#14262
danielayala94 merged 2 commits intomicrosoft:0.76-stablefrom
danielayala94:backportTelemetryPackageNames076

Conversation

@danielayala94
Copy link
Copy Markdown
Contributor

@danielayala94 danielayala94 commented Jan 8, 2025

Description

Backports #14259 to 0.76.

Fix to ensure that telemetry package names contain only the following characters: alphanumeric, underscore, dot. Also, make sure it starts with letter, and it has 100 characters or less.

Resolves #14218

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Why

The telemetry backend doesn't like that some of the packages contain characters like @ and -. This is problematic when trying to create dimensions that depend on the version of packages like:

react-native-windows
@react-native-community/cli

What

  • Added a condition to process package names in case it's not compliant with the rules described previously.
  • Introduced a new telemetry helper (nameUtils) with a couple of functions to verify and process package names. Replace all "bad" characters with underscores.

Screenshots

N/A

Testing

Ran the telemetry tests, and verified in the telemetry backend that all package versions are uploaded.

Changelog

No

Microsoft Reviewers: Open in CodeFlow

* Introducing package name processing

* Add trimming if string length > 100

* Change files
@danielayala94 danielayala94 requested review from a team as code owners January 8, 2025 23:43
@danielayala94 danielayala94 merged commit 2b94e2f into microsoft:0.76-stable Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants