Skip to content

[0.66] Expose text tooltip#969

Merged
Saadnajmi merged 2 commits intomicrosoft:0.66-stablefrom
Saadnajmi:tooltip-66
Jan 27, 2022
Merged

[0.66] Expose text tooltip#969
Saadnajmi merged 2 commits intomicrosoft:0.66-stablefrom
Saadnajmi:tooltip-66

Conversation

@Saadnajmi
Copy link
Copy Markdown
Collaborator

@Saadnajmi Saadnajmi commented Jan 19, 2022

Cherry pick #960 into 0.66-Stable

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

A client was reporting that tooltip wasn't showing up on the text component. This seems to be a simple one line fix.

Changelog

[macOS] [Fixed] - Fix Tooltip on Text not showing up

Test Plan

Checked the tooltip test page that tooltip on shows up.

Screen Shot 2022-01-14 at 10 28 53 PM

@Saadnajmi Saadnajmi requested a review from alloy as a code owner January 19, 2022 18:38
@Saadnajmi Saadnajmi changed the base branch from main to 0.66-stable January 19, 2022 18:44
@pull-bot
Copy link
Copy Markdown

pull-bot commented Jan 19, 2022

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than main. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on main first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Generated by 🚫 dangerJS against 5f8be3f

@Saadnajmi
Copy link
Copy Markdown
Collaborator Author

Closing till I get the CI in 0.66 in a better state.

@Saadnajmi Saadnajmi closed this Jan 19, 2022
@Saadnajmi Saadnajmi reopened this Jan 21, 2022
@Saadnajmi
Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

@Saadnajmi Saadnajmi merged commit 80cfcf7 into microsoft:0.66-stable Jan 27, 2022
@Saadnajmi Saadnajmi deleted the tooltip-66 branch January 27, 2022 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants