App delegate fixes for macOS#759
Merged
HeyImChris merged 12 commits intomicrosoft:0.63-stablefrom Apr 20, 2021
Merged
Conversation
* Update RCTCxxBridge.mm * add nullability checks
|
harrieshin
approved these changes
Apr 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
Pull in some AppDelegate changes we need for 0.63 to run properly
Changelog
[macOS] [Bug] - AppDelegate latest updates
Test Plan
I checked that some props are now getting set properly. This change makes macOS analogous to iOS which works in 0.63. I launched the test app and clicked through some screens like Button, ActivityIndicator, and DarkMode to make sure everything is loaded properly.