Skip to content

Cherry pick commit b3d41d3 to 0.62 [Minor tweaks to RCTDevSettings]#697

Merged
HeyImChris merged 1 commit intomicrosoft:0.62-stablefrom
nakambo:nakambo/rctdevsettings_0.62
Jan 27, 2021
Merged

Cherry pick commit b3d41d3 to 0.62 [Minor tweaks to RCTDevSettings]#697
HeyImChris merged 1 commit intomicrosoft:0.62-stablefrom
nakambo:nakambo/rctdevsettings_0.62

Conversation

@nakambo
Copy link
Copy Markdown
Collaborator

@nakambo nakambo commented Jan 26, 2021 •
edited by ghost
Loading

  • Export RCTDevSettings noop impl on shipping builds to JS

  • Add a protocol method to get all set keys on dev settings

  • tag changes

Microsoft Reviewers: Open in CodeFlow

@nakambo
Minor tweaks to RCTDevSettings (#696)
dff28db 
* Export RCTDevSettings noop impl on shipping builds to JS

* Add a protocol method to get all set keys on dev settings

* tag changes
@nakambo nakambo requested a review from HeyImChris January 26, 2021 22:40
@nakambo nakambo requested a review from tom-un as a code owner January 26, 2021 22:40
@pull-bot
Copy link
Copy Markdown

pull-bot commented Jan 26, 2021

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.
Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against dff28db

@HeyImChris HeyImChris merged commit 2bc9c5e into microsoft:0.62-stable Jan 27, 2021
@nakambo nakambo deleted the nakambo/rctdevsettings_0.62 branch January 27, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tom-un tom-un Awaiting requested review from tom-un tom-un is a code owner

1 more reviewer

@HeyImChris HeyImChris HeyImChris approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nakambo @pull-bot @HeyImChris