You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
I am making a fix / change for the macOS implementation of react-native
I am making a change required for Microsoft usage of react-native
Summary
This change is in master but we need to bring it over to the 0.60-stable branch as well since this is the branch sdx-platform is currently consuming.
This is needed to compile on Xcode12 beta 4. Previously we were successfully compiling on beta 2, but as things change between the betas this broke.
The compiler error is that it can't find the definition to a c++ function used for internal performance tracking/logging. We can explicitly include that framework (quartz) for macOS.
Created an OSS issue in this repo to track changes needed for the transition to Xcode 12 via issue #533 .
Changelog
[macOS] [Fixed] - Fix Xcode 12 beta 4 compiler error that we're missing a definition
Test Plan
If it compiles on macOS then it's fixed and shouldn't break anything. Built for iOS/macOS locally on Xcode 12 beta 4. CI will test again on Xcode 11 and soon on Xcode 12 beta 4.
❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.
⚠️
🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
Messages
📖
📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.
DetailsCATEGORY may be:
General
iOS
Android
JavaScript
Internal (for changes that do not need to be called out in the release notes)
TYPE may be:
Added, for new features.
Changed, for changes in existing functionality.
Deprecated, for soon-to-be removed features.
Removed, for now removed features.
Fixed, for any bug fixes.
Security, in case of vulnerabilities.
MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
The reason will be displayed to describe this comment to others. Learn more.
What does the TODO indicate in this case? From the perspective of a developer who might touch this code next, it's not clear to me what I should keep in mind or try to work towards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
This change is in master but we need to bring it over to the 0.60-stable branch as well since this is the branch sdx-platform is currently consuming.
This is needed to compile on Xcode12 beta 4. Previously we were successfully compiling on beta 2, but as things change between the betas this broke.
The compiler error is that it can't find the definition to a c++ function used for internal performance tracking/logging. We can explicitly include that framework (quartz) for macOS.
Created an OSS issue in this repo to track changes needed for the transition to Xcode 12 via issue #533 .
Changelog
[macOS] [Fixed] - Fix Xcode 12 beta 4 compiler error that we're missing a definition
Test Plan
If it compiles on macOS then it's fixed and shouldn't break anything. Built for iOS/macOS locally on Xcode 12 beta 4. CI will test again on Xcode 11 and soon on Xcode 12 beta 4.
Microsoft Reviewers: Open in CodeFlow