Skip to content

Fixes in the Nuget spec to unblock the publish task#508

Merged
tom-un merged 1 commit intomicrosoft:masterfrom
mganandraj:DroidPublishFix
Jul 21, 2020
Merged

Fixes in the Nuget spec to unblock the publish task#508
tom-un merged 1 commit intomicrosoft:masterfrom
mganandraj:DroidPublishFix

Conversation

@mganandraj
Copy link
Copy Markdown

@mganandraj mganandraj commented Jul 21, 2020

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Not a code change

Summary

Fix the nuget spec to pass the nuget pack step

Changelog

Fixes in the nuget spec to clear non-existing v8executor and a case sensitivity fix

Test Plan

Publish task should pass

Microsoft Reviewers: Open in CodeFlow

@pull-bot
Copy link
Copy Markdown

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against d278f79

@mganandraj mganandraj marked this pull request as ready for review July 21, 2020 00:45
@mganandraj mganandraj requested a review from tom-un as a code owner July 21, 2020 00:45
@tom-un tom-un merged commit 0aa3efa into microsoft:master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants