Get react-native building with Xcode 12 universal#504
Get react-native building with Xcode 12 universal#504HeyImChris merged 4 commits intomicrosoft:masterfrom
Conversation
|
| @property (nonatomic, assign) NSInteger selectedIndex; | ||
|
|
||
| @property (nonatomic, strong) RCTUIColor *color; // TODO(OSS Candidate ISS#2710739) | ||
| #if !TARGET_OS_OSX // [TODO(OSS Candidate ISS#2710739) // NSControl defines font prop for macOS, but iOS superviews don't |
There was a problem hiding this comment.
For my own sake: Where can I see the list of ISS bugs / where they are filed?
There was a problem hiding this comment.
There's an Issues tab at the top of the repo that shows them all https://github.com/microsoft/react-native-macos/issues
There was a problem hiding this comment.
This is a pretty generic bug we use to track diffs in our fork and actually come to think of it, these should all probably get fixed up with GitHub bugs instead of ADO ones
There was a problem hiding this comment.
Yeah I think we should stop attributing to the ADO one for sure - attributing to one single item doesn't have too much value and doesn't help during merges at all since if you're using a proper 3-way merge you don't need the additional context, your merge tool already will tell you what you've changed locally vs. what got changed in the other branch. I would vote towards not using these tags unless we can tag it with a github issue that is specific and maybe a good "first issue" candidate or we add comments to explain the divergence
Please select one of the following
Summary
Apple's new Silicon based machines require to be built with arm64. A precursor to that is we need to get building with Xcode 12 Universal. I built RN using Xcode 12 Universal Beta 2 and this fixes up the new errors.
All the errors I hit were around the font property on RCTPicker being invalid. We're overriding NSControl's font property but with stricter checking in Xcode 12 universal, we can't do this anymore. Instead, let's just use the NSControl prop on macOS and iOS and define the prop ourselves on iOS when we need to. This also has the benefit of reducing the amount of UIFont/NSFont macro calls.
Microsoft Reviewers: Open in CodeFlow