Skip to content

Fixed Voiceover reading of Text #476

Merged
tom-un merged 14 commits intomicrosoft:masterfrom
graytmatterMS:matgray/a11y-text-fix
Jul 15, 2020
Merged

Fixed Voiceover reading of Text #476
tom-un merged 14 commits intomicrosoft:masterfrom
graytmatterMS:matgray/a11y-text-fix

Conversation

@graytmatterMS
Copy link
Copy Markdown

@graytmatterMS graytmatterMS commented Jun 26, 2020

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

The contents of TextViews were not being announced by Voiceover. I.e. when Voiceover's focus was on some text element it would just read out "text" rather than whatever actual content was in the element. This is unexpected behavior and would have caused visually impaired users to be unable to read the vast majority of the textual information in our experiences.

Changelog

[MacOS] [Fixed] - Fixed Voiceover reading of Text

Test Plan

  1. Compile and run app.
  2. Navigate to Text page
  3. Turn on Voiceover.
  4. Navigate to any Text.
  • You should hear/see voiceover announce the text inside the element.
Microsoft Reviewers: Open in CodeFlow

@graytmatterMS graytmatterMS requested a review from tom-un as a code owner June 26, 2020 23:30
Copy link
Copy Markdown
Collaborator

@tom-un tom-un left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change per my comments in the review

@ghost ghost removed the Needs: Author Feedback label Jul 1, 2020
@tom-un
Copy link
Copy Markdown
Collaborator

tom-un commented Jul 14, 2020

@graytmatterMS as we discussed offline, i can take over this PR.

Cleanup some comments and whitespace.
@tom-un tom-un merged commit a073278 into microsoft:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants