Fixed Voiceover reading of Text #476
Merged
tom-un merged 14 commits intomicrosoft:masterfrom Jul 15, 2020
Merged
Conversation
anandrajeswaran
requested changes
Jun 27, 2020
tom-un
requested changes
Jun 29, 2020
Collaborator
tom-un
left a comment
There was a problem hiding this comment.
Please change per my comments in the review
Collaborator
|
@graytmatterMS as we discussed offline, i can take over this PR. |
Cleanup some comments and whitespace.
tom-un
approved these changes
Jul 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
The contents of TextViews were not being announced by Voiceover. I.e. when Voiceover's focus was on some text element it would just read out "text" rather than whatever actual content was in the element. This is unexpected behavior and would have caused visually impaired users to be unable to read the vast majority of the textual information in our experiences.
Changelog
[MacOS] [Fixed] - Fixed Voiceover reading of Text
Test Plan
Microsoft Reviewers: Open in CodeFlow