Implementing AccessibilityInfo.DisplayOptions ex: isInvertColorsEnabled#455
Merged
tom-un merged 19 commits intomicrosoft:masterfrom Jun 19, 2020
Merged
Conversation
analysis-bot
suggested changes
Jun 16, 2020
analysis-bot
left a comment
There was a problem hiding this comment.
Code analysis results:
eslintfound some issues. Runyarn lint --fixto automatically fix problems.
tom-un
requested changes
Jun 17, 2020
tom-un
reviewed
Jun 17, 2020
Collaborator
|
Uh, oh. The macOS CI tests crashed in the AccessiblityExample LoadAllPages tests. https://dev.azure.com/ms/react-native/_build/results?buildId=88462&view=logs&j=628dfcdf-afa5-5702-e4da-dfa310a93062&t=65c699ef-104f-5f6e-4efa-350cb1662389. You can run the test locally: Cmd+U to run all the test, then you can manually re-run the LoadAllPages tests by clicking the little run arrow on that test. The only guess I have as to why its crashing is because you're not unobserving the notification in the dealloc. |
analysis-bot
suggested changes
Jun 18, 2020
analysis-bot
left a comment
There was a problem hiding this comment.
Code analysis results:
eslintfound some issues. Runyarn lint --fixto automatically fix problems.
tom-un
approved these changes
Jun 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
When the MacOS fork was made all the AccessibilityInfo functionality was stubbed out because the iOS Accessibility APIs are different from the MacOS APIs. I am implementing several AccessibilityInfo properties and EvenListeners. This will allow a application to tell if several Accessible Display Options are enabled, or if they change.
Specifically this PR implements AccessibilityInfo.isInvertColorsEnabled AccessibilityInfo.isReduceMotionEnabled and AccessibilityInfo.isReduceTransparencyEnabled.
Changelog
[MacOS] [Added] - Implemented AccessibilityInfo.isInvertColorsEnabled, isReduceMotionEnabled, & isReduceTransparencyEnabled
Test Plan
Microsoft Reviewers: Open in CodeFlow