Fix RCTScrollContentView layout with fixed size#453
Merged
tom-un merged 1 commit intomicrosoft:masterfrom Jun 20, 2020
Merged
Conversation
51f6a11 to
f6be201
Compare
tom-un
reviewed
Jun 16, 2020
tom-un
requested changes
Jun 16, 2020
Collaborator
tom-un
left a comment
There was a problem hiding this comment.
This is a huge improvement. Thanks!
I think it needs a similar affordance for when horizontal={true} for the vertical scroll indicator. See my other comment.
f6be201 to
a906b53
Compare
a906b53 to
905a16f
Compare
tom-un
requested changes
Jun 19, 2020
905a16f to
13700d4
Compare
tom-un
approved these changes
Jun 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Always show the vertical scroll bar when Show scroll bars is set to Always. This makes it consistent with other system apps, such as Finder or Xcode.
Resolves #363
Changelog
[macOS] [Fixed] - Fix RCTScrollContentView layout with fixed size
Test Plan
For reference, here's Xcode with Show scroll bars set to Always:
Microsoft Reviewers: Open in CodeFlow