Skip to content

Fix styling of single-line TextInput#449

Merged
tom-un merged 1 commit intomicrosoft:masterfrom
tido64:fix-single-line-input-placeholder-styling
Jun 16, 2020
Merged

Fix styling of single-line TextInput#449
tom-un merged 1 commit intomicrosoft:masterfrom
tido64:fix-single-line-input-placeholder-styling

Conversation

@tido64
Copy link
Copy Markdown
Member

@tido64 tido64 commented Jun 12, 2020

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

In single line TextInput controls, most text stylings in the style prop are being ignored.

Resolves #447

Changelog

[macOS] [Fixed] - Fix styling of single-line TextInput

Test Plan

image image
Microsoft Reviewers: Open in CodeFlow

@tido64 tido64 requested a review from tom-un as a code owner June 12, 2020 11:53
@tido64 tido64 marked this pull request as draft June 12, 2020 13:24
@tido64 tido64 changed the title Fix styling of single-line TextInput placeholder Fix styling of single-line TextInput Jun 12, 2020
@tido64 tido64 force-pushed the fix-single-line-input-placeholder-styling branch from 946e56f to 4887fa1 Compare June 12, 2020 13:44
@tido64 tido64 marked this pull request as ready for review June 12, 2020 13:44
@tido64 tido64 force-pushed the fix-single-line-input-placeholder-styling branch from 4887fa1 to 0f8b62a Compare June 12, 2020 13:45
@tom-un tom-un merged commit 8b6a438 into microsoft:master Jun 16, 2020
@tido64 tido64 deleted the fix-single-line-input-placeholder-styling branch June 16, 2020 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In single line TextInput controls, most text stylings in the style prop are being ignored

2 participants