Fix ActivityIndicator with custom color causing brief flicker#446
Merged
tom-un merged 1 commit intomicrosoft:masterfrom Jun 17, 2020
Merged
Fix ActivityIndicator with custom color causing brief flicker#446tom-un merged 1 commit intomicrosoft:masterfrom
tom-un merged 1 commit intomicrosoft:masterfrom
Conversation
96f848f to
b04f477
Compare
tom-un
approved these changes
Jun 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The window flickers when rendering a view with an
ActivityIndicatorand a custom colour. This is caused by setting-[NSView setContentFilters:].Resolves #412
Changelog
[macOS] [Fixed] - Fix ActivityIndicator with custom color causing brief flicker
Test Plan
Microsoft Reviewers: Open in CodeFlow