Skip to content

Working around ndk paths containing spaces in it#445

Merged
tom-un merged 2 commits intomicrosoft:masterfrom
mganandraj:NDKPATHWITHSPACE
Jun 11, 2020
Merged

Working around ndk paths containing spaces in it#445
tom-un merged 2 commits intomicrosoft:masterfrom
mganandraj:NDKPATHWITHSPACE

Conversation

@mganandraj
Copy link
Copy Markdown

@mganandraj mganandraj commented Jun 10, 2020 •
edited by ghost
Loading

#419 ## Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

This changes are only in ADO pipeline definitions.

Summary

Many Android build tools doesn't support spaces in the SDK/NDK paths. But we do sometimes find lab images with paths having spaces in it. This change creates a symlink to the NDK path and feed it into the build task to get around.

Changelog

Many Android build tools doesn't support spaces in the SDK/NDK paths. But we do sometimes find lab images with paths having spaces in it. This change creates a symlink to the NDK path and feed it into the build task to get around.

[CATEGORY] [TYPE] - Message

Test Plan

Ensure build pipelines pass

Microsoft Reviewers: Open in CodeFlow

@pull-bot
Copy link
Copy Markdown

pull-bot commented Jun 10, 2020 •
edited
Loading

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 32bef84

@mganandraj mganandraj marked this pull request as ready for review June 11, 2020 04:05
@mganandraj mganandraj requested a review from tom-un as a code owner June 11, 2020 04:05
@mganandraj mganandraj requested a review from acoates-ms June 11, 2020 04:05
@mganandraj mganandraj self-assigned this Jun 11, 2020
@tom-un tom-un merged commit 22028b4 into microsoft:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tom-un tom-un tom-un approved these changes

@acoates-ms acoates-ms Awaiting requested review from acoates-ms

Assignees

@mganandraj mganandraj

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mganandraj @pull-bot @tom-un