Fix backgroundColor not being applied correctly to TextInput#443
Merged
tom-un merged 2 commits intomicrosoft:masterfrom Jun 17, 2020
Merged
Fix backgroundColor not being applied correctly to TextInput#443tom-un merged 2 commits intomicrosoft:masterfrom
backgroundColor not being applied correctly to TextInput#443tom-un merged 2 commits intomicrosoft:masterfrom
Conversation
tom-un
reviewed
Jun 11, 2020
| #if TARGET_OS_OSX // [TODO(macOS ISS#2323203) | ||
| self.bordered = NO; | ||
| self.accessibilityRole = NSAccessibilityTextFieldRole; | ||
| self.backgroundColor = [NSColor clearColor]; |
Collaborator
There was a problem hiding this comment.
Does RCTUITextView.m for multi-line TextInputs just work when backgroundColor is set?
Member
Author
There was a problem hiding this comment.
I think so?
diff --git a/RNTester/js/examples/TextInput/TextInputExample.ios.js b/RNTester/js/examples/TextInput/TextInputExample.ios.js
index f21ca72d3..c8bb90377 100644
--- a/RNTester/js/examples/TextInput/TextInputExample.ios.js
+++ b/RNTester/js/examples/TextInput/TextInputExample.ios.js
@@ -530,6 +530,7 @@ const styles = StyleSheet.create({
padding: 4,
},
multiline: {
+ backgroundColor: '#ff00ff',
borderWidth: StyleSheet.hairlineWidth,
borderColor: '#0f0f0f',
flex: 1,backgroundColor not being applied to correctly to TextInputbackgroundColor not being applied correctly to TextInput
tom-un
approved these changes
Jun 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
backgroundColornot being applied correctly toTextInput(single-line).Resolves #415
Changelog
[macOS] [Fixed] - Fix
backgroundColornot being applied correctly to TextInputTest Plan
Microsoft Reviewers: Open in CodeFlow