Fixed bug that causes bidirectional type inference to be skipped whe…#10577
Merged
Fixed bug that causes bidirectional type inference to be skipped whe…#10577
Conversation
… the target of an assignment is a member access expression (`base.member`) and the base expression is a module. This addresses #10539.
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: sympy (https://github.com/sympy/sympy)
+ .../projects/sympy/sympy/utilities/matchpy_connector.py:288:16 - error: Type "Basic" is not assignable to declared type "Expr"
+ "Basic" is not assignable to "Expr" (reportAssignmentType)
- 33296 errors, 74 warnings, 0 informations
+ 33297 errors, 74 warnings, 0 informations
zulip (https://github.com/zulip/zulip)
+ Type "_StrOrPromise" is not assignable to type "Iterable[Any] | Container[Any]"
+ Type "_StrPromise" is not assignable to type "Iterable[Any] | Container[Any]"
+ "_StrPromise" is incompatible with protocol "Iterable[Any]"
+ "__iter__" is not present
+ "_StrPromise" is incompatible with protocol "Container[Any]"
+ "__contains__" is an incompatible type
+ Type "(o: str, /) -> bool" is not assignable to type "(x: object, /) -> bool" (reportArgumentType)
+ .../projects/zulip/zerver/tests/test_email_notifications.py:155:60 - error: Argument of type "_StrOrPromise" cannot be assigned to parameter "container" of type "Iterable[Any] | Container[Any]" in function "assertIn"
- 4329 errors, 359 warnings, 0 informations
+ 4330 errors, 359 warnings, 0 informations
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n the target of an assignment is a member access expression (
base.member) and the base expression is a module. This addresses #10539.