This repository was archived by the owner on Aug 2, 2023. It is now read-only.
Fix problems with running ptvsd. #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
approved these changes
Apr 4, 2018
DonJayamanne
reviewed
Apr 4, 2018
Contributor
DonJayamanne
left a comment
There was a problem hiding this comment.
@ericsnowcurrently got some tests failing. I trust you'll fix them, hence approved.
int19h
approved these changes
Apr 4, 2018
79f65c9 to
a1bf02b
Compare
Codecov Report
@@ Coverage Diff @@
## master #306 +/- ##
==========================================
+ Coverage 57.4% 62.66% +5.26%
==========================================
Files 10 11 +1
Lines 1850 1875 +25
==========================================
+ Hits 1062 1175 +113
+ Misses 788 700 -88
Continue to review full report at Codecov.
|
This was referenced Apr 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #266 inadvertently introduced some backward-incompatible changes to how the ptvsd CLI works. This PR fixes them.
I've also added a number of unit tests. In a follow-up PR I'll be adding some full-stack tests using sockets and subprocess.
(should resolve #292, #299, #302, and (partially) #301)