Skip to content

Support for TIFF format in Depth Compression#180

Merged
chitsaw merged 4 commits into
microsoft:masterfrom
CMU-TBD:PR-Depth-TIFF-Encoder
Jul 26, 2021
Merged

Support for TIFF format in Depth Compression#180
chitsaw merged 4 commits into
microsoft:masterfrom
CMU-TBD:PR-Depth-TIFF-Encoder

Conversation

@xiangzhi

Copy link
Copy Markdown
Contributor

This pull request add the support to encode/decode depth image with TIFF compression format. TIFF format has been used in application such as ROS to encode depth images. The code/design for this PR is based on the PNG encoder/decoder.

Changes:

  • Add TIFF as an DepthCompressionMethod.
  • Added Encoder/Decoder for Windows.
  • Added test for TIFF encoding/decoding.

Let me know if any changes are required

@chitsaw chitsaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting these additions! Please see comments.

Comment thread Sources/Imaging/Microsoft.Psi.Imaging.Windows/DepthImageFromTiffStreamDecoder.cs Outdated
Comment thread Sources/Imaging/Test.Psi.Imaging.Windows/ImageTester.cs Outdated
Comment thread Sources/Imaging/Microsoft.Psi.Imaging.Windows/DepthImageCompressor.cs Outdated
Comment thread Sources/Imaging/Microsoft.Psi.Imaging.Linux/DepthImageCompressor.cs Outdated
@xiangzhi

Copy link
Copy Markdown
Contributor Author

Thanks for the review. I just made the suggested changes.

@chitsaw chitsaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

@chitsaw chitsaw merged commit 7c7d0ae into microsoft:master Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants