Skip to content

Conversation

@mingxwa
Copy link
Member

@mingxwa mingxwa commented May 6, 2024

Changes

  • Added support for custom base classes potentially using CRTP.
  • Added default implementations of base classes for macros PRO_DEF_*_DISPATCH* by redirecting the invocation to the proxy with the name of the dispatch.
  • Added a unit test case for this change, and refactored some other unit test cases with the new feature.

@mingxwa mingxwa requested review from guominrui, lyf6lyf and tian-lt May 6, 2024 15:33
@mingxwa mingxwa marked this pull request as draft May 6, 2024 15:43
@mingxwa mingxwa changed the title Add support for optional base classes Add support for custom accessors May 7, 2024
@mingxwa mingxwa marked this pull request as ready for review May 7, 2024 13:14
@mingxwa mingxwa merged commit dc44c4a into microsoft:main May 8, 2024
@mingxwa mingxwa deleted the user/mingxwa/base branch May 8, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants