Skip to content

Conversation

@frederick-vs-ja
Copy link
Contributor

Fixes #36.

See also LWG2839.

@frederick-vs-ja
Copy link
Contributor Author

It seems to me that cases TestMoveAssignment_FromValue_ToSelf and TestSwap_Value_Self are testing bad designs.

Copy link
Member

@mingxwa mingxwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! LGTM

@mingxwa mingxwa merged commit deee3c6 into microsoft:main Jan 18, 2024
@frederick-vs-ja frederick-vs-ja deleted the fix-self-move-assignment branch January 19, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test targets compile failed for the [-Werror=uninitialized] compile option for non MSVC compiler(gcc11.2)

2 participants