Skip to content

Improve proxy_indirect_accessor #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mingxwa merged 1 commit into from
Aug 18, 2025
Merged

Improve proxy_indirect_accessor #335

mingxwa merged 1 commit into from
Aug 18, 2025

Conversation

@mingxwa
Copy link
Member

@mingxwa mingxwa commented Aug 16, 2025 •
edited
Loading

The following code compiles today, but should be rejected:

#include <proxy/proxy.h>

struct Any : pro::facade_builder::build {};

int main() {
  auto p = pro::make_proxy<Any>(123);
  auto pi = *p; // proxy_indirect_accessor shall not be copied or moved. Any subsequent use of pi invokes undefined behavior.
}

Added unit tests accordingly.

@mingxwa mingxwa requested review from guominrui and tian-lt August 16, 2025 11:12
@mingxwa mingxwa merged commit 8934033 into microsoft:main Aug 18, 2025
9 checks passed
@mingxwa mingxwa deleted the user/mingxwa/ctor branch August 18, 2025 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tian-lt tian-lt tian-lt approved these changes

@guominrui guominrui guominrui approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mingxwa @tian-lt @guominrui