Skip to content

Conversation

@mingxwa
Copy link
Member

@mingxwa mingxwa commented Jun 18, 2025

Changes

  • Fixed a typo in README
  • Added /utf-8 when building modules with MSVC, similar to fmt
  • Relaced std::construct_at(this, ...) and std::destroy_at(this) in proxy with private function calls. Otherwise, UB is inevitable (like reset()), although it passes unit tests.
  • Removed null initialization form details::invocation_meta and meta_ptr_indirect_impl as they are no longer required.

@mingxwa mingxwa requested review from guominrui and tian-lt June 18, 2025 02:22
@mingxwa mingxwa merged commit 2ff24c6 into microsoft:main Jun 18, 2025
9 checks passed
@mingxwa mingxwa deleted the user/mingxwa/comments branch June 18, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants