Attach environment information to benchmarking report #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR attaches build environment information to the benchmarking reports by adding steps in each CI workflow to dump the environment details into an output file and updating paths accordingly.
- Add new steps to create a drop folder and dump environment info via scripts
- Update benchmark execution commands to output results into the new drop folder
- Modify artifact names/paths to reflect the changes
Reviewed Changes
| File | Description |
|---|---|
| .github/workflows/bvt-msvc.yml | Adds cl.exe to PATH and a step to dump environment info; updates benchmark output path and artifact name |
| .github/workflows/bvt-appleclang.yml | Introduces environment dump step and changes benchmark result path and artifact name |
| .github/workflows/bvt-gcc.yml | Integrates a step to dump environment info and updates benchmarking artifact paths |
| .github/workflows/bvt-nvhpc.yml | Adds environment info dump step and revises benchmark output and artifact naming |
| .github/workflows/bvt-clang.yml | Inserts step to dump build environment and changes benchmark execution and artifact path |
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (5)
.github/workflows/bvt-msvc.yml:24
- [nitpick] Consider defining a variable for the 'build\drop' directory so that the folder path is maintained consistently and any future changes only require an update in one place.
mkdir build\drop > $null
.github/workflows/bvt-appleclang.yml:26
- [nitpick] Consider abstracting the 'build/drop' directory path into a variable to reduce duplication and ease future maintenance.
mkdir build/drop
.github/workflows/bvt-gcc.yml:29
- [nitpick] Consider defining a centralized variable for the build drop directory to ensure directory paths remain uniform and easier to update.
mkdir build/drop
.github/workflows/bvt-nvhpc.yml:29
- [nitpick] Consider refactoring the drop folder creation into a reusable variable or step to maintain consistency across workflows.
mkdir build/drop
.github/workflows/bvt-clang.yml:29
- [nitpick] Consider centralizing the definition of the 'build/drop' directory by using a variable, which can help prevent issues if the path needs updating in the future.
mkdir build/drop
tian-lt
previously approved these changes
Mar 7, 2025
tian-lt
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example:
Environment
Tested locally. No functional changes.