Prefer static operator() if available
#267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR updates the CI workflows to support building and testing the "proxy" component in C++23 mode, aligning with the new static operator() convention. Key changes include:
- Updating various workflow files to use C++23 by setting the CMAKE_CXX_STANDARD flag.
- Consolidating build directories for several CI jobs.
- Adding a new compatibility test workflow for C++20 mode with Clang.
Reviewed Changes
| File | Description |
|---|---|
| .github/workflows/bvt-compatibility.yml | New workflow file for C++20 compatibility builds. |
| .github/workflows/bvt-appleclang.yml | Updated build command to enforce C++23. |
| .github/workflows/bvt-msvc.yml | Updated build command and runner version. |
| .github/workflows/bvt-clang.yml | Streamlined to use clang-19 with C++23. |
| .github/workflows/bvt-gcc.yml | Consolidated build directory and enforced C++23. |
| .github/workflows/bvt-nvhpc.yml | Consolidated build directory and enforced C++23. |
| .github/workflows/pipeline-ci.yml | Added a step to run the new compatibility workflow. |
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
tian-lt
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Static
operator()is a C++23 feature that can improve code generation. Although won't help much in optimized builds, it's the recommended way to define anoperator()function nowadays. Resolves #258.Changes
static operator()if available.proxyin C++23 mode with the latest compilers.bvt-compatibility.ymlto buildproxyin C++20 mode.-Wno-c++2b-extensionsis required for Clang in C++20 mode to avoid warnings when building tests.