Relax the constraints on basic_facade_builder::support_weak
#266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guominrui
approved these changes
Mar 4, 2025
tian-lt
reviewed
Mar 5, 2025
| template <class P> | ||
| auto operator()(const P& self) const noexcept | ||
| requires(requires { typename P::weak_type; } && | ||
| std::is_convertible_v<const P&, typename P::weak_type>) |
Collaborator
There was a problem hiding this comment.
adding lock() as a requirement as well?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, only
std::shared_ptrand the return type of(allocate|make)_proxy()can instantiate aproxy<F>ifFwas built withsupport_weak. The constraints can be relaxed sincestd::shared_ptrhas a member typeweak_type. After this change, any pointer type that has implemented aweak_typecan work withsupport_weak.