Skip to content

Feature: Support for std::format #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mingxwa merged 8 commits into from
Jan 9, 2025
Merged

Feature: Support for std::format #228

mingxwa merged 8 commits into from
Jan 9, 2025

Conversation

@mingxwa
Copy link
Member

@mingxwa mingxwa commented Jan 4, 2025 •
edited
Loading

Changes

  • Added options support_format and support_wformat to basic_facade_builder to enable support for std::format().
  • Added unit tests accordingly.

Documentation and sample code will be updated later.

@mingxwa mingxwa requested review from guominrui and tian-lt January 4, 2025 12:12
tian-lt
tian-lt previously approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@tian-lt tian-lt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

guominrui
guominrui approved these changes Jan 9, 2025
View reviewed changes
@mingxwa mingxwa merged commit f34bb8f into microsoft:main Jan 9, 2025
7 of 8 checks passed
@mingxwa mingxwa deleted the user/mingxwa/format branch January 9, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guominrui guominrui guominrui approved these changes

@tian-lt tian-lt tian-lt left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mingxwa @tian-lt @guominrui