Improve accessibility in debugging #199
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Member functions of
proxycannot be called from a debugger, making it difficult to debug with a value ofproxyfrom client code.Changes
details::symbol_guardto guide symbol generation in a debug build (whenNODEBUGis not defined).proxy::operator->andproxy::operator*.operator_dispatch,conversion_dispatch,PRO_DEF_MEM_DISPATCH,PRO_DEF_FREE_AS_MEM_DISPATCHand the dispatch type generated forbasic_facade_builder::add_facade<F, true>.proxyaccordingly to ensure template instantiation happens at the right spots.Verification
Build the following code with MSVC in debug mode (without using the value of
proxyin the code):Set a breakpoint at the end of
mainand inspect the value ofpin the debugger. The debugger invokes the correct function for me.