Skip to content

[Promptflow Serve] Benchmarking Framework To Measure Throughput of Promptflow Serve#3486

Merged
wangchao1230 merged 4 commits into
microsoft:mainfrom
dasiths:dasithw/benchmarking-framework
Jul 2, 2024
Merged

[Promptflow Serve] Benchmarking Framework To Measure Throughput of Promptflow Serve#3486
wangchao1230 merged 4 commits into
microsoft:mainfrom
dasiths:dasithw/benchmarking-framework

Conversation

@dasiths

@dasiths dasiths commented Jun 29, 2024

Copy link
Copy Markdown
Member

Description

This PR introduces a throughput benchmarking framework for Promptflow Serve which introduces tests for the following scenarios.

  • WSGI + Flask + DAG + Sync Nodes
  • ASGI + FastApi + DAG + Async Nodes
  • ASGI + FastApi + Flex Flow + Async Nodes

It uses a minimum example that has a flow as shown below. The scenario covers 3 parallelly executing nodes (i.e. simulating guardrails) and upon completion of those, one other node that calls an http endpoint (i.e. simulating LLM or custom API).

image

The tests are controlled by the configuration parameters in the benchmark/promptflow-serve/test_runner/settings.env file.

The makefile located at benchmark/promptflow-serve/makefile

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Contributions

This PR contains contributions from @david-ratcliffe and @swetha-sundar.

dasiths added 2 commits June 30, 2024 03:31
Signed-off-by: Dasith Wijes <git@dasith.me>
Signed-off-by: Dasith Wijes <git@dasith.me>
@dasiths dasiths requested a review from a team as a code owner June 29, 2024 17:50
brynn-code
brynn-code previously approved these changes Jul 1, 2024
Signed-off-by: Dasith Wijes <git@dasith.me>
Signed-off-by: Dasith Wijes <git@dasith.me>
@dasiths dasiths requested a review from brynn-code July 1, 2024 16:02
@wangchao1230 wangchao1230 merged commit 8fb8cbe into microsoft:main Jul 2, 2024
@dasiths dasiths deleted the dasithw/benchmarking-framework branch July 2, 2024 05:11
@dasiths

dasiths commented Jul 2, 2024

Copy link
Copy Markdown
Member Author

Thanks everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants