Users/mbarbour/update for async add component#644
Merged
Conversation
Updating PowerPlatform CLI wrapper.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds support for running the add-solution-component action asynchronously by introducing a new run-asynchronously input, updating related code paths and tests, and bumping a CLI-wrapper dependency.
- Introduced
run-asynchronouslyinput inaction.ymlwith defaultfalse - Wired the new input through
actionLaunch.tsandindex.ts - Updated tests to include the new input and bumped
@microsoft/powerplatform-cli-wrapperversion
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| add-solution-component/action.yml | Added run-asynchronously input with default false |
| src/actions/add-solution-component/actionLaunch.ts | Set default INPUT_RUN-ASYNCHRONOUSLY env var |
| src/actions/add-solution-component/index.ts | Passed new run-asynchronously input to addSolutionComponent |
| src/test/addSolutionComponent.test.ts | Updated test parameters to include the new input |
| package.json | Bumped @microsoft/powerplatform-cli-wrapper to ^0.1.134 |
Comments suppressed due to low confidence (2)
src/actions/add-solution-component/index.ts:34
- [nitpick] Using
asyncas a property name is ambiguous and shadows the async keyword. Consider renaming it torunAsynchronouslyor similar to match the input name and improve clarity.
async: parameterMap['run-asynchronously'],
src/test/addSolutionComponent.test.ts:46
- Tests currently only cover the default
falsecase. Add a test scenario whererun-asynchronouslyis set totrueto verify asynchronous execution paths.
+ async: { name: 'run-asynchronously', required: false, defaultValue: 'false' }
petrochuk
approved these changes
May 22, 2025
petrochuk
approved these changes
May 22, 2025
tehcrashxor
reviewed
May 23, 2025
petrochuk
approved these changes
May 23, 2025
tehcrashxor
reviewed
May 23, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
tehcrashxor
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for running the "add-solution-component" operation asynchronously by adding a new input parameter and updating the related code and tests. Additionally, it updates a dependency version in
package.json.Feature Addition: Asynchronous Operation Support
add-solution-component/action.yml: Added a new input parameterrun-asynchronouslyto allow the operation to run asynchronously, with a default value offalse.src/actions/add-solution-component/actionLaunch.ts: Set theINPUT_RUN-ASYNCHRONOUSLYenvironment variable tofalseby default.src/actions/add-solution-component/index.ts: Passed the newrun-asynchronouslyparameter to theaddSolutionComponentfunction.src/test/addSolutionComponent.test.ts: Updated tests to include therun-asynchronouslyparameter with its default value offalse.Dependency Update
package.json: Updated the version of@microsoft/powerplatform-cli-wrapperfrom^0.1.129to^0.1.134.