fix(extension): arm inactivity timers for all pending tabs#1443
Merged
yury-s merged 1 commit intomicrosoft:mainfrom Mar 13, 2026
Merged
Conversation
When multiple selector tabs have pending relay connections, _onTabActivated returned after scheduling the first timeout. This prevented other inactive pending tabs from timing out and could leave stale relay connections alive indefinitely.
yury-s
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This patch fixes a control-flow bug in the extension background script where
_onTabActivatedwould stop after scheduling a timeout for the first inactive pending tab.With multiple entries in
_pendingTabSelection, only one tab got timeout handling per activation event.Changes
returninTabShareExtension._onTabActivatedso the loop evaluates all pending tabs.Why
Without this, inactive pending tabs can remain pending indefinitely (unless another tab activation happens to process them later), which may leave stale relay connection state around longer than intended.
Validation
npm run lint --workspace @playwright/mcp-extensionnpm run test --workspace @playwright/mcp-extension -- --listFixes #1442