Skip to content

feat: support non-ref selectors in mcp and cli#39581

Merged
dgozman merged 2 commits intomicrosoft:mainfrom
dgozman:ref-or-selector
Mar 11, 2026
Merged

feat: support non-ref selectors in mcp and cli#39581
dgozman merged 2 commits intomicrosoft:mainfrom
dgozman:ref-or-selector

Conversation

@dgozman
Copy link
Copy Markdown
Collaborator

@dgozman dgozman commented Mar 9, 2026

No description provided.

pavelfeldman
pavelfeldman reviewed Mar 10, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@pavelfeldman pavelfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update SKILLs too.

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
pavelfeldman
pavelfeldman approved these changes Mar 10, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@pavelfeldman pavelfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure we don't expose these to MCP

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 11, 2026

Test results for "MCP"

1 failed
❌ [chromium] › mcp/sse.spec.ts:158 › sse transport browser lifecycle (persistent) @mcp-macos-latest

5191 passed, 164 skipped

Merge workflow run.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 11, 2026

Test results for "tests 1"

2 failed
❌ [playwright-test] › reporter.spec.ts:251 › merged › should not have internal error when steps are finished after timeout @macos-latest-node20
❌ [playwright-test] › ui-mode-test-output.spec.ts:118 › should collapse repeated console messages for test @ubuntu-latest-node20

6 flaky ⚠️ [chromium-library] › library/tracing.spec.ts:432 › should produce screencast frames fit `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1230 › should display language-specific locators `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/popup.spec.ts:260 › should not throw when click closes popup `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-page] › page/page-history.spec.ts:95 › goBack/goForward should work with bfcache-able pages `@chromium-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1080 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:185 › should show snapshots for steps `@macos-latest-node20`

38916 passed, 848 skipped

Merge workflow run.

@dgozman dgozman merged commit daa14b5 into microsoft:main Mar 11, 2026
35 of 38 checks passed
@github-actions github-actions bot mentioned this pull request Mar 31, 2026
Closed
Copilot AI mentioned this pull request Mar 31, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dgozman @pavelfeldman