Skip to content

fix(ui-mode): restore console character spacing#37540

Merged
yury-s merged 1 commit intomicrosoft:mainfrom
agg23:ui-mode-console-spacing-fix
Sep 23, 2025
Merged

fix(ui-mode): restore console character spacing#37540
yury-s merged 1 commit intomicrosoft:mainfrom
agg23:ui-mode-console-spacing-fix

Conversation

@agg23
Copy link
Contributor

@agg23 agg23 commented Sep 23, 2025

The newest version of xterm.js isn't able to properly calculate the size of the used font when a CSS variable is used. Since we are not likely to ever change this value and we never provided any web fonts, hardcode it to monospace, which is the font we always were using anyway.

Screenshot 2025-09-23 at 12 01 46 PM

@agg23 agg23 requested a review from pavelfeldman September 23, 2025 19:05
@github-actions
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › runner.spec.ts:118 › should ignore subprocess creation error because of SIGINT @macos-latest-node18-1

5 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node18`
⚠️ [firefox-page] › page/page-emulate-media.spec.ts:144 › should keep reduced motion and color emulation after reload `@firefox-ubuntu-22.04-node18`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:397 › should work behind reverse proxy `@macos-latest-node18-1`
⚠️ [installation tests] › playwright-electron-should-work.spec.ts:31 › electron should work with special characters in path `@package-installations-windows-latest`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:637 › should indicate current test status `@ubuntu-latest-node24-1`

46976 passed, 821 skipped


Merge workflow run.

Copy link
Member

@yury-s yury-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I reverted the xterm deps in #37539, we should revert that once you change lands. Your fix looks good on mac and linux.

@yury-s yury-s merged commit 1e774e1 into microsoft:main Sep 23, 2025
32 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants