chore: use explicit matcher call context#34620
Merged
yury-s merged 1 commit intomicrosoft:mainfrom Feb 5, 2025
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
yury-s
approved these changes
Feb 5, 2025
| return function(this: any, ...args: any[]) { | ||
| const { isNot, promise, utils } = this; | ||
| const context = getMatcherCallContext(); | ||
| const timeout = context.expectInfo.timeout ?? context?.testInfo?._projectInternal?.expect?.timeout ?? defaultExpectTimeout; |
Member
There was a problem hiding this comment.
Suggested change
| const timeout = context.expectInfo.timeout ?? context?.testInfo?._projectInternal?.expect?.timeout ?? defaultExpectTimeout; | |
| const timeout = context.expectInfo.timeout ?? context.testInfo?._projectInternal?.expect?.timeout ?? defaultExpectTimeout; |
7b4b43e to
14e859c
Compare
This comment has been minimized.
This comment has been minimized.
yury-s
reviewed
Feb 5, 2025
| wrappedMatchers[key] = wrappedMatchers[name]; | ||
| Object.defineProperty(wrappedMatchers[key], 'name', { value: name }); | ||
| extendedMatchers[name] = wrappedMatchers[key]; | ||
| extendedMatchers[name] = matcher; |
Member
There was a problem hiding this comment.
createExpect(info, qualifier, { ...customMatchers, ...matchers });
yury-s
approved these changes
Feb 5, 2025
14e859c to
e193c9a
Compare
yury-s
approved these changes
Feb 5, 2025
Contributor
Test results for "tests 1"11 flaky37785 passed, 655 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.