Skip to content

cherry-pick(#32189): fix(only-changed): show nice error message about shallow clones#32190

Merged
Skn0tt merged 1 commit intorelease-1.46from
cherry-pick-1.46-2024-08-16-09-42-34
Aug 16, 2024
Merged

cherry-pick(#32189): fix(only-changed): show nice error message about shallow clones#32190
Skn0tt merged 1 commit intorelease-1.46from
cherry-pick-1.46-2024-08-16-09-42-34

Conversation

@playwrightmachine
Copy link
Contributor

@playwrightmachine playwrightmachine commented Aug 16, 2024

This PR cherry-picks the following commits:

@Skn0tt Skn0tt merged commit 301f179 into release-1.46 Aug 16, 2024
@Skn0tt Skn0tt deleted the cherry-pick-1.46-2024-08-16-09-42-34 branch August 16, 2024 09:46
@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2024

Test results for "tests others"

17777 passed, 478 skipped
✔️✔️✔️

Merge workflow run.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2024

Test results for "tests 1"

2 flaky ⚠️ [chromium-library] › library/page-clock.spec.ts:343:3 › popup › should not run time before popup on pause
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work

29494 passed, 855 skipped
✔️✔️✔️

Merge workflow run.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2024

Test results for "tests 2"

6 fatal errors, not part of any test
19 failed
❌ [chromium-library] › library/inspector/cli-codegen-java.spec.ts:92:5 › should work with --save-har
❌ [chromium-library] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified
❌ [chromium-library] › library/proxy.spec.ts:240:3 › should use socks proxy in second page
❌ [chromium-library] › library/proxy.spec.ts:256:3 › does launch without a port
❌ [chromium-page] › page/page-screenshot.spec.ts:283:5 › page screenshot › should work for canvas
❌ [chromium-library] › library/capabilities.spec.ts:141:3 › should not crash on showDirectoryPicker
❌ [chromium-library] › library/capabilities.spec.ts:141:3 › should not crash on showDirectoryPicker
❌ [chromium-library] › library/capabilities.spec.ts:141:3 › should not crash on showDirectoryPicker
❌ [chromium-library] › library/proxy.spec.ts:180:3 › should exclude patterns
❌ [chromium-library] › library/proxy.spec.ts:230:3 › should use socks proxy
❌ [chromium-library] › library/proxy.spec.ts:240:3 › should use socks proxy in second page
❌ [chromium-library] › library/proxy.spec.ts:256:3 › does launch without a port
❌ [chromium-page] › page/page-screenshot.spec.ts:283:5 › page screenshot › should work for canvas
❌ [webkit-library] › library/client-certificates.spec.ts:190:3 › fetch › should throw a http error if the pfx passphrase is incorect
❌ [webkit-library] › library/client-certificates.spec.ts:204:3 › fetch › should fail with matching certificates in legacy pfx format
❌ [webkit-library] › library/client-certificates.spec.ts:190:3 › fetch › should throw a http error if the pfx passphrase is incorect
❌ [webkit-library] › library/client-certificates.spec.ts:204:3 › fetch › should fail with matching certificates in legacy pfx format
❌ [webkit-library] › library/client-certificates.spec.ts:190:3 › fetch › should throw a http error if the pfx passphrase is incorect
❌ [webkit-library] › library/client-certificates.spec.ts:204:3 › fetch › should fail with matching certificates in legacy pfx format

103 flaky ⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [chromium-library] › library/chromium/oopif.spec.ts:260:3 › ElementHandle.boundingBox() should work
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:665:5 › run-server › should fulfill with global fetch result
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:867:7 › run-server › socks proxy › should proxy based on the pattern
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:63:5 › launch server › should provide an error when ws endpoint is incorrect
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:43:5 › should use logger in default context
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:317:5 › should connect via https
⚠️ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:120:3 › should support viewport option
⚠️ [chromium-library] › library/download.spec.ts:391:5 › download event › should delete downloads on browser gone
⚠️ [chromium-library] › library/har.spec.ts:82:3 › should have pages in persistent context
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:493:7 › cli codegen › should --save-trace
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:147:5 › should work with --save-har
⚠️ [chromium-library] › library/inspector/cli-codegen-python.spec.ts:78:5 › should save the codegen output to a file if specified
⚠️ [chromium-library] › library/page-clock.spec.ts:264:3 › stubTimers › replaces global performance.now
⚠️ [chromium-library] › library/proxy.spec.ts:230:3 › should use socks proxy
⚠️ [chromium-library] › library/proxy.spec.ts:326:3 › should use SOCKS proxy for websocket requests
⚠️ [chromium-library] › library/signals.spec.ts:78:7 › signals › should close the browser on SIGINT
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:76:7 › cli codegen › should click after same-document navigation
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:791:7 › cli codegen › should click button with nested div
⚠️ [chromium-page] › page/page-mouse.spec.ts:166:3 › should trigger hover state
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [chromium-page] › page/locator-misc-1.spec.ts:28:3 › should hover when Node is removed
⚠️ [chromium-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [chromium-library] › library/chromium/oopif.spec.ts:260:3 › ElementHandle.boundingBox() should work
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [chromium-library] › library/chromium/oopif.spec.ts:260:3 › ElementHandle.boundingBox() should work
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [firefox-library] › library/capabilities.spec.ts:260:3 › requestFullscreen
⚠️ [firefox-library] › library/page-clock.spec.ts:147:3 › runFor › passes 2 hours, 34 minutes and 10 seconds
⚠️ [firefox-library] › library/video.spec.ts:381:5 › screencast › should capture navigation
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [firefox-library] › library/video.spec.ts:189:5 › screencast › should capture static page
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [firefox-library] › library/video.spec.ts:189:5 › screencast › should capture static page
⚠️ [firefox-page] › page/page-mouse.spec.ts:166:3 › should trigger hover state
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [firefox-page] › page/locator-misc-1.spec.ts:21:3 › should hover @smoke
⚠️ [firefox-page] › page/page-goto.spec.ts:182:3 › should properly cancel Cross-Origin-Opener-Policy navigation
⚠️ [firefox-library] › library/browsercontext-add-cookies.spec.ts:141:3 › should isolate persistent cookies
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [firefox-library] › library/browsercontext-timezone-id.spec.ts:20:3 › should work @smoke
⚠️ [firefox-library] › library/hit-target.spec.ts:398:3 › should click in iframe with padding
⚠️ [firefox-library] › library/trace-viewer.spec.ts:625:1 › should preserve currentSrc
⚠️ [firefox-page] › page/page-click-scroll.spec.ts:101:3 › should scroll into view element in iframe
⚠️ [firefox-page] › page/page-click.spec.ts:97:3 › should click the 1x1 div
⚠️ [firefox-page] › page/page-dialog.spec.ts:112:3 › should auto-dismiss the alert without listeners
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:665:5 › run-server › should fulfill with global fetch result
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:26:5 › should connect to an existing cdp session
⚠️ [chromium-library] › library/chromium/launcher.spec.ts:28:3 › should not throw with remote-debugging-port argument
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:493:7 › cli codegen › should --save-trace
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should work with --save-har
⚠️ [chromium-library] › library/proxy.spec.ts:32:3 › should use proxy @smoke
⚠️ [chromium-library] › library/proxy.spec.ts:326:3 › should use SOCKS proxy for websocket requests
⚠️ [chromium-library] › library/tracing.spec.ts:350:5 › should survive browser.close with auto-created traces dir
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [chromium-library] › library/emulation-focus.spec.ts:202:12 › should trigger hover state concurrently
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [chromium-library] › library/popup.spec.ts:264:3 › should not throw when click closes popup
⚠️ [firefox-page] › page/page-goto.spec.ts:182:3 › should properly cancel Cross-Origin-Opener-Policy navigation
⚠️ [firefox-page] › page/page-set-input-files.spec.ts:40:3 › should upload a folder
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:553:7 › cli codegen › should select
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:493:7 › cli codegen › should --save-trace
⚠️ [webkit-page] › page/page-request-continue.spec.ts:184:5 › post data › should amend post data
⚠️ [webkit-library] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:444:7 › cli codegen › should generate getByAltText
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1128:1 › should pick locator in iframe
⚠️ [webkit-page] › page/workers.spec.ts:106:3 › should clear upon navigation
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [webkit-library] › library/popup.spec.ts:115:3 › should inherit viewport size from browser context
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:40:3 › should upload a folder
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [webkit-library] › library/browsercontext-reuse.spec.ts:206:1 › should reset mouse position
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:521:7 › cli codegen › should uncheck
⚠️ [webkit-library] › library/beforeunload.spec.ts:46:3 › should close page with beforeunload listener
⚠️ [webkit-library] › library/browsercontext-viewport.spec.ts:145:12 › should drag with high dpi
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:56:7 › cli codegen › should ignore programmatic events
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:426:7 › cli codegen › should emit single keyup on ArrowDown
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:276:7 › cli codegen › should handle dialogs
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:704:7 › cli codegen › should assert value on disabled select
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [webkit-library] › library/tracing.spec.ts:412:14 › should produce screencast frames scale

220127 passed, 9530 skipped, 5579 did not run
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CQ1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@playwrightmachine @Skn0tt