Skip to content

cherry-pick(#28239): fix: collect all errors in removeFolders#28243

Merged
mxschmitt merged 1 commit intorelease-1.40from
cherry-pick-1.40-2023-11-20-09-59-02
Nov 20, 2023
Merged

cherry-pick(#28239): fix: collect all errors in removeFolders#28243
mxschmitt merged 1 commit intorelease-1.40from
cherry-pick-1.40-2023-11-20-09-59-02

Conversation

@playwrightmachine
Copy link
Contributor

@playwrightmachine playwrightmachine commented Nov 20, 2023

This PR cherry-picks the following commits:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2023

Test results for "tests 1"

5 flaky ⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/fetch-proxy.spec.ts:30:3 › context request should pick up proxy credentials
⚠️ [firefox] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:165:5 › should update tracing network live
⚠️ [webkit] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks

26145 passed, 612 skipped
✔️✔️✔️

Merge workflow run.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2023

Test results for "tests 2"

2 fatal errors, not part of any test
14 failed
❌ [chromium] › library/chromium/oopif.spec.ts:315:3 › should emit filechooser event for iframe
❌ [chromium] › library/chromium/oopif.spec.ts:315:3 › should emit filechooser event for iframe
❌ [chromium] › library\chromium\oopif.spec.ts:315:3 › should emit filechooser event for iframe
❌ [chromium] › library/headful.spec.ts:121:3 › should(not) block third party cookies
❌ [chromium] › library/headful.spec.ts:287:3 › headless and headful should use same default fonts
❌ [firefox] › library\browsercontext-basic.spec.ts:236:3 › should work with offline option
❌ [firefox] › library\video.spec.ts:189:5 › screencast › should capture static page
❌ [chromium] › library\chromium\oopif.spec.ts:315:3 › should emit filechooser event for iframe
❌ [webkit] › library/capabilities.spec.ts:287:3 › Intl.ListFormat should work
❌ [webkit] › library/capabilities.spec.ts:287:3 › Intl.ListFormat should work
❌ [webkit] › library\capabilities.spec.ts:34:3 › Web Assembly should work @smoke
❌ [webkit] › library\emulation-focus.spec.ts:190:12 › should trigger hover state concurrently
❌ [webkit] › library/capabilities.spec.ts:287:3 › Intl.ListFormat should work
❌ [webkit] › library\capabilities.spec.ts:34:3 › Web Assembly should work @smoke

87 flaky ⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/chromium/oopif.spec.ts:260:3 › ElementHandle.boundingBox() should work
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/chromium/oopif.spec.ts:260:3 › ElementHandle.boundingBox() should work
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library\tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/chromium/tracing.spec.ts:21:3 › should output a trace
⚠️ [chromium] › library/chromium/oopif.spec.ts:315:3 › should emit filechooser event for iframe
⚠️ [chromium] › library/emulation-focus.spec.ts:190:12 › should trigger hover state concurrently
⚠️ [chromium] › page/page-drag.spec.ts:34:5 › Drag and drop › should send the right events
⚠️ [chromium] › page/page-drag.spec.ts💯5 › Drag and drop › should cancel on escape
⚠️ [chromium] › library/chromium/oopif.spec.ts:283:3 › should click
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library\trace-viewer.spec.ts:721:1 › should open two trace files
⚠️ [chromium] › library\video.spec.ts:551:5 › screencast › should capture static page in persistent context @smoke
⚠️ [chromium] › library/chromium/oopif.spec.ts:330:3 › should not throw on exposeFunction when oopif detaches
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-event-request.spec.ts:130:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library\tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/headful.spec.ts:55:3 › should not crash when creating second context
⚠️ [chromium] › library/headful.spec.ts:68:3 › should click when viewport size is larger than screen
⚠️ [chromium] › library/headful.spec.ts:83:3 › should dispatch click events to oversized viewports
⚠️ [chromium] › library/headful.spec.ts:107:3 › should click background tab
⚠️ [chromium] › library/headful.spec.ts:193:3 › should not override viewport size when passed null
⚠️ [chromium] › library/headful.spec.ts:211:3 › Page.bringToFront should work
⚠️ [chromium] › library\tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/headful.spec.ts:83:3 › should dispatch click events to oversized viewports
⚠️ [chromium] › library/headful.spec.ts:107:3 › should click background tab
⚠️ [chromium] › library/headful.spec.ts:121:3 › should(not) block third party cookies
⚠️ [chromium] › library/headful.spec.ts:157:3 › should not block third party SameSite=None cookies
⚠️ [chromium] › library/headful.spec.ts:193:3 › should not override viewport size when passed null
⚠️ [chromium] › library/headful.spec.ts:211:3 › Page.bringToFront should work
⚠️ [chromium] › library/headful.spec.ts:287:3 › headless and headful should use same default fonts
⚠️ [chromium] › library\tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/browsercontext-network-event.spec.ts:59:3 › BrowserContext.Events.RequestFailed
⚠️ [firefox] › library\tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/capabilities.spec.ts:256:3 › requestFullscreen
⚠️ [firefox] › library/emulation-focus.spec.ts:65:3 › should not affect mouse event target page
⚠️ [firefox] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/video.spec.ts:351:5 › screencast › should capture navigation
⚠️ [firefox] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/video.spec.ts:189:5 › screencast › should capture static page
⚠️ [firefox] › library/video.spec.ts:165:5 › screencast › should work with old options
⚠️ [firefox] › page/page-event-request.spec.ts:162:3 › should return response body when Cross-Origin-Opener-Policy is set
⚠️ [firefox] › library\browsercontext-add-cookies.spec.ts:141:3 › should isolate persistent cookies
⚠️ [firefox] › library\browsercontext-pages.spec.ts:128:3 › should not leak listeners during navigation of 20 pages
⚠️ [firefox] › library\fetch-proxy.spec.ts:30:3 › context request should pick up proxy credentials
⚠️ [firefox] › library\hit-target.spec.ts:259:3 › should not click an element overlaying iframe with the target
⚠️ [firefox] › library\tracing.spec.ts:288:5 › should overwrite existing file
⚠️ [firefox] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/capabilities.spec.ts💯3 › should play audio @smoke
⚠️ [firefox] › page/page-event-request.spec.ts:162:3 › should return response body when Cross-Origin-Opener-Policy is set
⚠️ [firefox] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library\fetch-proxy.spec.ts:30:3 › context request should pick up proxy credentials
⚠️ [firefox] › library\tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/chromium/oopif.spec.ts:330:3 › should not throw on exposeFunction when oopif detaches
⚠️ [chromium] › library/selector-generator.spec.ts:41:5 › selector generator › should generate text and normalize whitespace
⚠️ [chromium] › page/page-leaks.spec.ts:62:5 › click should not leak
⚠️ [chromium] › library/browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [chromium] › library/chromium/oopif.spec.ts:315:3 › should emit filechooser event for iframe
⚠️ [chromium] › page/page-drag.spec.ts💯5 › Drag and drop › should cancel on escape
⚠️ [chromium] › library\tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/video.spec.ts:351:5 › screencast › should capture navigation
⚠️ [webkit] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [webkit] › page/page-event-console.spec.ts:38:3 › should emit same log twice
⚠️ [webkit] › page/page-goto.spec.ts:797:3 › should wait for load when iframe attaches and detaches
⚠️ [webkit] › page/elementhandle-misc.spec.ts:27:3 › should hover when Node is removed
⚠️ [webkit] › page/page-drag.spec.ts:246:5 › Drag and drop › should work if the drag event is captured but not canceled
⚠️ [webkit] › page/selectors-react.spec.ts:58:7 › react18 › should query by props combinations
⚠️ [webkit] › page/wheel.spec.ts:185:3 › should scroll horizontally
⚠️ [webkit] › page/elementhandle-misc.spec.ts:27:3 › should hover when Node is removed
⚠️ [webkit] › page/page-drag.spec.ts:25:5 › Drag and drop › should work @smoke
⚠️ [webkit] › page/selectors-react.spec.ts:33:7 › react16 › should work with single-root elements @smoke
⚠️ [webkit] › library\browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [webkit] › library\inspector\cli-codegen-1.spec.ts:667:7 › cli codegen › should assert navigation
⚠️ [webkit] › library\inspector\cli-codegen-3.spec.ts:383:7 › cli codegen › should generate getByTestId
⚠️ [webkit] › library\inspector\cli-codegen-3.spec.ts:444:7 › cli codegen › should generate getByAltText
⚠️ [webkit] › library\inspector\cli-codegen-3.spec.ts:502:7 › cli codegen › should generate getByLabel without regex
⚠️ [webkit] › page\page-drag.spec.ts:272:5 › Drag and drop › should work if a frame is stalled
⚠️ [webkit] › page\page-drag.spec.ts:337:3 › should work if not doing a drag
⚠️ [webkit] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [webkit] › page/page-event-console.spec.ts:38:3 › should emit same log twice

171683 passed, 7637 skipped, 11 did not run
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt merged commit e27bc9f into release-1.40 Nov 20, 2023
@mxschmitt mxschmitt deleted the cherry-pick-1.40-2023-11-20-09-59-02 branch November 20, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgozman dgozman dgozman approved these changes

Assignees

No one assigned

Labels

CQ1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@playwrightmachine @dgozman @mxschmitt